On Thu, Oct 17, 2019 at 06:29:27PM -0300, Eduardo Habkost wrote: > On Thu, Oct 17, 2019 at 05:11:29PM -0400, John Snow wrote: > > > > > > On 10/16/19 3:24 PM, Eduardo Habkost wrote: > > > This series ports image-fuzzer to Python 3. > > > > > > Eduardo Habkost (10): > > > image-fuzzer: Open image files in binary mode > > > image-fuzzer: Write bytes instead of string to image file > > > image-fuzzer: Explicitly use integer division operator > > > image-fuzzer: Use io.StringIO > > > image-fuzzer: Use %r for all fiels at Field.__repr__() > > > image-fuzzer: Return bytes objects on string fuzzing functions > > > image-fuzzer: Use bytes constant for field values > > > image-fuzzer: Encode file name and file format to bytes > > > image-fuzzer: Run using python3 > > > image-fuzzer: Use errors parameter of subprocess.Popen() > > > > > > tests/image-fuzzer/qcow2/__init__.py | 1 - > > > tests/image-fuzzer/qcow2/fuzz.py | 54 +++++++++++++------------- > > > tests/image-fuzzer/qcow2/layout.py | 57 ++++++++++++++-------------- > > > tests/image-fuzzer/runner.py | 12 +++--- > > > 4 files changed, 61 insertions(+), 63 deletions(-) > > > > > > > When I gave my try at converting this to python3 I noticed that the > > "except OSError as e" segments used e[1] in a way that was not seemingly > > supported. > > > > Did you fix that in this series or did I miss it? > > Good catch, I hadn't noticed that. I didn't fix it.
Separate patch sent for that issue: https://lore.kernel.org/qemu-devel/20191021214117.18091-1-ehabk...@redhat.com/ -- Eduardo
