Am 01.10.2019 um 21:15 hat Markus Armbruster geschrieben: > The QAPI code generator clocks in at some 3100 SLOC in 8 source files. > Almost 60% of the code is in qapi/common.py. Split it into more > focused modules: > > * Move QAPISchemaPragma and QAPISourceInfo to qapi/source.py. > > * Move QAPIError and its sub-classes to qapi/error.py. > > * Move QAPISchemaParser and QAPIDoc to parser.py. Use the opportunity > to put QAPISchemaParser first. > > * Move check_expr() & friends to qapi/expr.py. Use the opportunity to > put the code into a more sensible order. > > * Move QAPISchema & friends to qapi/schema.py > > * Move QAPIGen and its sub-classes, ifcontext, > QAPISchemaModularCVisitor, and QAPISchemaModularCVisitor to qapi/gen.py > > A number of helper functions remain in qapi/common.py. I considered > moving the code generator helpers to qapi/gen.py, but decided not to. > Perhaps we should rewrite them as methods of QAPIGen some day. > > Signed-off-by: Markus Armbruster <arm...@redhat.com>
This patch seems to forget to change qapi-py in the Makefile, so that when you change one of the new source files, the generator won't run again. Kevin
