On Mon, Oct 07, 2019 at 10:40:55AM +0200, Cédric Le Goater wrote: > Include the XIVE_TRIGGER_PQ bit in the trigger data which is how > hardware signals to the IC that the PQ bits of the interrupt source > have been checked. > > Signed-off-by: Cédric Le Goater <c...@kaod.org>
Applied to ppc-for-4.2, thanks.
> ---
> hw/ppc/pnv_psi.c | 15 ++++++++++++---
> 1 file changed, 12 insertions(+), 3 deletions(-)
>
> diff --git a/hw/ppc/pnv_psi.c b/hw/ppc/pnv_psi.c
> index a997f16bb4e6..68d0dfacfe2b 100644
> --- a/hw/ppc/pnv_psi.c
> +++ b/hw/ppc/pnv_psi.c
> @@ -660,10 +660,19 @@ static void pnv_psi_notify(XiveNotifier *xf, uint32_t
> srcno)
>
> uint32_t offset =
> (psi->regs[PSIHB_REG(PSIHB9_IVT_OFFSET)] >> PSIHB9_IVT_OFF_SHIFT);
> - uint64_t lisn = cpu_to_be64(offset + srcno);
> + uint64_t data = XIVE_TRIGGER_PQ | offset | srcno;
> + MemTxResult result;
>
> - if (valid) {
> - cpu_physical_memory_write(notify_addr, &lisn, sizeof(lisn));
> + if (!valid) {
> + return;
> + }
> +
> + address_space_stq_be(&address_space_memory, notify_addr, data,
> + MEMTXATTRS_UNSPECIFIED, &result);
> + if (result != MEMTX_OK) {
> + qemu_log_mask(LOG_GUEST_ERROR, "%s: trigger failed @%"
> + HWADDR_PRIx "\n", __func__, notif_port);
> + return;
> }
> }
>
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature
