Patchew URL: https://patchew.org/QEMU/20191001155319.8066-1-vsement...@virtuozzo.com/
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20191001155319.8066-1-vsement...@virtuozzo.com Subject: [PATCH v4 00/31] error: auto propagated local_err === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 Switched to a new branch 'test' f0134cb ivshmem: Fix error_append_hint/error_prepend usage 927e8d8 PVRDMA: Fix error_append_hint/error_prepend usage c901c43 nbd: Fix error_append_hint/error_prepend usage a990496 Sockets: Fix error_append_hint/error_prepend usage 7e9b7be Migration: Fix error_append_hint/error_prepend usage c37742f QOM: Fix error_append_hint/error_prepend usage e2d8729 cmdline: Fix error_append_hint/error_prepend usage 111a147 chardev: Fix error_append_hint/error_prepend usage 7f7095d block: Fix error_append_hint/error_prepend usage 42992e2 XIVE: Fix error_append_hint/error_prepend usage aef0d72 virtio-9p: Fix error_append_hint/error_prepend usage fadcc18 virtio: Fix error_append_hint/error_prepend usage 0b46fe6 vhost: Fix error_append_hint/error_prepend usage 2b5a95f VFIO: Fix error_append_hint/error_prepend usage 17cff57 USB: Fix error_append_hint/error_prepend usage b8c7bd2 SCSI: Fix error_append_hint/error_prepend usage 2833abc PCI: Fix error_append_hint/error_prepend usage 61a303e PowerNV (Non-Virtualized): Fix error_append_hint/error_prepend usage c287bb4 Boston: Fix error_append_hint/error_prepend usage 163ff63 ASPEED BMCs: Fix error_append_hint/error_prepend usage 1eb85cb SmartFusion2: Fix error_append_hint/error_prepend usage a29bb2d arm: Fix error_append_hint/error_prepend usage af781f2 PowerPC TCG CPUs: Fix error_append_hint/error_prepend usage 00ceb2b ARM TCG CPUs: Fix error_append_hint/error_prepend usage a8ac50c s390: Fix error_append_hint/error_prepend usage 82e8c8b python: add commit-per-subsystem.py a97cab0 scripts: add script to fix error_append_hint/error_prepend usage 987fd13 error: auto propagated local_err b209564 net/net: fix local variable shadowing in net_client_init 896b2dd hw/core/loader-fit: fix freeing errp in fit_load_fdt cd953ee errp: rename errp to errp_in where it is IN-argument === OUTPUT BEGIN === 1/31 Checking commit cd953ee1bb8c (errp: rename errp to errp_in where it is IN-argument) 2/31 Checking commit 896b2dde85c4 (hw/core/loader-fit: fix freeing errp in fit_load_fdt) 3/31 Checking commit b209564a3bf7 (net/net: fix local variable shadowing in net_client_init) 4/31 Checking commit 987fd13e64fc (error: auto propagated local_err) ERROR: Macros with multiple statements should be enclosed in a do - while loop #71: FILE: include/qapi/error.h:357: +#define ERRP_AUTO_PROPAGATE() \ +g_auto(ErrorPropagator) __auto_errp_prop = {.errp = errp}; \ +errp = ((errp == NULL || *errp == error_fatal) ? \ + &__auto_errp_prop.local_err : errp) total: 1 errors, 0 warnings, 43 lines checked Patch 4/31 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 5/31 Checking commit a97cab09ecd5 (scripts: add script to fix error_append_hint/error_prepend usage) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #16: new file mode 100644 total: 0 errors, 1 warnings, 28 lines checked Patch 5/31 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 6/31 Checking commit 82e8c8bfa5e9 (python: add commit-per-subsystem.py) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #13: new file mode 100755 total: 0 errors, 1 warnings, 69 lines checked Patch 6/31 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 7/31 Checking commit a8ac50cc35ed (s390: Fix error_append_hint/error_prepend usage) 8/31 Checking commit 00ceb2bad505 (ARM TCG CPUs: Fix error_append_hint/error_prepend usage) 9/31 Checking commit af781f20f6a2 (PowerPC TCG CPUs: Fix error_append_hint/error_prepend usage) 10/31 Checking commit a29bb2dcb2b9 (arm: Fix error_append_hint/error_prepend usage) 11/31 Checking commit 1eb85cb68ba5 (SmartFusion2: Fix error_append_hint/error_prepend usage) 12/31 Checking commit 163ff63668f9 (ASPEED BMCs: Fix error_append_hint/error_prepend usage) 13/31 Checking commit c287bb4ab3b2 (Boston: Fix error_append_hint/error_prepend usage) 14/31 Checking commit 61a303eb291b (PowerNV (Non-Virtualized): Fix error_append_hint/error_prepend usage) 15/31 Checking commit 2833abc764d5 (PCI: Fix error_append_hint/error_prepend usage) 16/31 Checking commit b8c7bd233ee3 (SCSI: Fix error_append_hint/error_prepend usage) 17/31 Checking commit 17cff57051b2 (USB: Fix error_append_hint/error_prepend usage) 18/31 Checking commit 2b5a95f33325 (VFIO: Fix error_append_hint/error_prepend usage) 19/31 Checking commit 0b46fe629163 (vhost: Fix error_append_hint/error_prepend usage) 20/31 Checking commit fadcc18dfb3d (virtio: Fix error_append_hint/error_prepend usage) 21/31 Checking commit aef0d72aef21 (virtio-9p: Fix error_append_hint/error_prepend usage) 22/31 Checking commit 42992e22ff24 (XIVE: Fix error_append_hint/error_prepend usage) 23/31 Checking commit 7f7095d05e79 (block: Fix error_append_hint/error_prepend usage) 24/31 Checking commit 111a1472baf3 (chardev: Fix error_append_hint/error_prepend usage) 25/31 Checking commit e2d872961ff8 (cmdline: Fix error_append_hint/error_prepend usage) 26/31 Checking commit c37742f15571 (QOM: Fix error_append_hint/error_prepend usage) 27/31 Checking commit 7e9b7bef90c8 (Migration: Fix error_append_hint/error_prepend usage) 28/31 Checking commit a9904966d137 (Sockets: Fix error_append_hint/error_prepend usage) 29/31 Checking commit c901c432d406 (nbd: Fix error_append_hint/error_prepend usage) 30/31 Checking commit 927e8d8a6586 (PVRDMA: Fix error_append_hint/error_prepend usage) 31/31 Checking commit f0134cb1157d (ivshmem: Fix error_append_hint/error_prepend usage) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20191001155319.8066-1-vsement...@virtuozzo.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com