Hi all!
Here is a proposal of auto propagation for local_err, to not call
error_propagate on every exit point, when we deal with local_err.
There are also two issues with errp:
1. error_fatal & error_append_hint/error_prepend: user can't see this
additional info, because exit() happens in error_setg earlier than info
is added. [Reported by Greg Kurz]
2. error_abort & error_propagate: when we wrap
error_abort by local_err+error_propagate, resulting coredump will
refer to error_propagate and not to the place where error happened.
(the macro itself don't fix the issue, but it allows to [3.] drop all
local_err+error_propagate pattern, which will definitely fix the issue)
[Reported by Kevin Wolf]
Still, applying new macro to all errp-functions is a huge task, which is
impossible to solve in one series.
So, here is a minimum: solve only [1.], by adding new macro to all
errp-functions which wants to call error_append_hint.
v4;
02: - check errp to be not NULL
- drop Eric's r-b
03: add Eric's r-b
04: - rename macro to ERRP_AUTO_PROPAGATE [Kevin]
- improve comment and commit msg, mention
error_prepend
05: - handle error_prepend too
- use new macro name
- drop empty line at the end
commit message for auto-generated commits updated,
commits regenerated.
I'll use cc-cmd to cc appropriate recipients per patch, still
cover-letter together with 04-06 patches should be interesting for
all:
CC: kw...@redhat.com
CC: mre...@redhat.com
CC: js...@redhat.com
CC: f...@euphon.net
CC: s...@weilnetz.de
CC: codypr...@gmail.com
CC: marcandre.lur...@redhat.com
CC: pbonz...@redhat.com
CC: gr...@kaod.org
CC: sundeep.l...@gmail.com
CC: peter.mayd...@linaro.org
CC: stefa...@redhat.com
CC: pbur...@wavecomp.com
CC: arik...@wavecomp.com
CC: berra...@redhat.com
CC: ehabk...@redhat.com
CC: da...@gibson.dropbear.id.au
CC: c...@kaod.org
CC: m...@redhat.com
CC: marcel.apfelb...@gmail.com
CC: mark.cave-ayl...@ilande.co.uk
CC: yuval.sh...@oracle.com
CC: coh...@redhat.com
CC: far...@linux.ibm.com
CC: r...@twiddle.net
CC: da...@redhat.com
CC: pa...@linux.ibm.com
CC: borntrae...@de.ibm.com
CC: kra...@redhat.com
CC: alex.william...@redhat.com
CC: and...@aj.id.au
CC: j...@jms.id.au
CC: ebl...@redhat.com
CC: arm...@redhat.com
CC: mdr...@linux.vnet.ibm.com
CC: quint...@redhat.com
CC: dgilb...@redhat.com
CC: jasow...@redhat.com
CC: qemu-bl...@nongnu.org
CC: integrat...@gluster.org
CC: qemu-...@nongnu.org
CC: qemu-...@nongnu.org
CC: qemu-s3...@nongnu.org
Vladimir Sementsov-Ogievskiy (31):
errp: rename errp to errp_in where it is IN-argument
hw/core/loader-fit: fix freeing errp in fit_load_fdt
net/net: fix local variable shadowing in net_client_init
error: auto propagated local_err
scripts: add script to fix error_append_hint/error_prepend usage
python: add commit-per-subsystem.py
s390: Fix error_append_hint/error_prepend usage
ARM TCG CPUs: Fix error_append_hint/error_prepend usage
PowerPC TCG CPUs: Fix error_append_hint/error_prepend usage
arm: Fix error_append_hint/error_prepend usage
SmartFusion2: Fix error_append_hint/error_prepend usage
ASPEED BMCs: Fix error_append_hint/error_prepend usage
Boston: Fix error_append_hint/error_prepend usage
PowerNV (Non-Virtualized): Fix error_append_hint/error_prepend usage
PCI: Fix error_append_hint/error_prepend usage
SCSI: Fix error_append_hint/error_prepend usage
USB: Fix error_append_hint/error_prepend usage
VFIO: Fix error_append_hint/error_prepend usage
vhost: Fix error_append_hint/error_prepend usage
virtio: Fix error_append_hint/error_prepend usage
virtio-9p: Fix error_append_hint/error_prepend usage
XIVE: Fix error_append_hint/error_prepend usage
block: Fix error_append_hint/error_prepend usage
chardev: Fix error_append_hint/error_prepend usage
cmdline: Fix error_append_hint/error_prepend usage
QOM: Fix error_append_hint/error_prepend usage
Migration: Fix error_append_hint/error_prepend usage
Sockets: Fix error_append_hint/error_prepend usage
nbd: Fix error_append_hint/error_prepend usage
PVRDMA: Fix error_append_hint/error_prepend usage
ivshmem: Fix error_append_hint/error_prepend usage
include/block/nbd.h | 1 +
include/monitor/hmp.h | 2 +-
include/qapi/error.h | 39 +++++++++++-
ui/vnc.h | 2 +-
block.c | 3 +
block/backup.c | 1 +
block/dirty-bitmap.c | 1 +
block/file-posix.c | 4 ++
block/gluster.c | 2 +
block/qcow.c | 1 +
block/qcow2-bitmap.c | 1 +
block/qcow2.c | 3 +
block/vdi.c | 1 +
block/vhdx-log.c | 1 +
block/vmdk.c | 1 +
block/vpc.c | 1 +
chardev/spice.c | 1 +
hw/9pfs/9p-local.c | 1 +
hw/9pfs/9p-proxy.c | 1 +
hw/9pfs/9p.c | 1 +
hw/arm/msf2-soc.c | 1 +
hw/arm/virt.c | 2 +
hw/block/dataplane/virtio-blk.c | 1 +
hw/core/loader-fit.c | 7 ++-
hw/core/qdev-properties-system.c | 1 +
hw/intc/arm_gicv3_kvm.c | 1 +
hw/intc/pnv_xive.c | 1 +
hw/intc/xive.c | 3 +
hw/misc/ivshmem.c | 1 +
hw/misc/msf2-sysreg.c | 1 +
hw/pci-bridge/pcie_root_port.c | 1 +
hw/ppc/mac_newworld.c | 1 +
hw/ppc/pnv_lpc.c | 1 +
hw/ppc/pnv_occ.c | 1 +
hw/ppc/spapr.c | 1 +
hw/ppc/spapr_irq.c | 1 +
hw/ppc/spapr_pci.c | 1 +
hw/rdma/vmw/pvrdma_main.c | 1 +
hw/s390x/s390-ccw.c | 1 +
hw/scsi/scsi-disk.c | 1 +
hw/scsi/scsi-generic.c | 1 +
hw/scsi/vhost-scsi.c | 1 +
hw/usb/ccid-card-emulated.c | 1 +
hw/vfio/common.c | 3 +
hw/vfio/pci-quirks.c | 1 +
hw/vfio/pci.c | 3 +
hw/vfio/platform.c | 1 +
hw/virtio/vhost-vsock.c | 1 +
hw/virtio/virtio-pci.c | 2 +
hw/watchdog/wdt_aspeed.c | 1 +
migration/migration.c | 1 +
migration/savevm.c | 2 +
monitor/hmp-cmds.c | 8 +--
nbd/client.c | 5 ++
nbd/server.c | 4 ++
net/net.c | 17 +++--
qdev-monitor.c | 2 +
target/ppc/kvm.c | 2 +
target/s390x/cpu_models.c | 2 +
ui/vnc.c | 10 +--
util/error.c | 8 +--
util/qemu-option.c | 2 +
util/qemu-sockets.c | 2 +
python/commit-per-subsystem.py | 69 +++++++++++++++++++++
scripts/coccinelle/fix-error-add-info.cocci | 28 +++++++++
65 files changed, 247 insertions(+), 27 deletions(-)
create mode 100755 python/commit-per-subsystem.py
create mode 100644 scripts/coccinelle/fix-error-add-info.cocci
--
2.21.0
