Patchew URL: https://patchew.org/QEMU/20190925110639.100699-1-sam...@google.com/
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20190925110639.100699-1-sam...@google.com Subject: [PATCH v7 0/8] Add Qemu to SeaBIOS LCHS interface === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu deee6ff..c6f5012 master -> master - [tag update] patchew/1569590461-12562-1-git-send-email-mjros...@linux.ibm.com -> patchew/1569590461-12562-1-git-send-email-mjros...@linux.ibm.com - [tag update] patchew/1569591203-15258-1-git-send-email-imbre...@linux.ibm.com -> patchew/1569591203-15258-1-git-send-email-imbre...@linux.ibm.com * [new tag] patchew/20190927101110.25581-1-berra...@redhat.com -> patchew/20190927101110.25581-1-berra...@redhat.com * [new tag] patchew/20190927134224.14550-1-marcandre.lur...@redhat.com -> patchew/20190927134224.14550-1-marcandre.lur...@redhat.com * [new tag] patchew/20190927134639.4284-1-arm...@redhat.com -> patchew/20190927134639.4284-1-arm...@redhat.com * [new tag] patchew/20190927141728.7137-1-cr...@redhat.com -> patchew/20190927141728.7137-1-cr...@redhat.com Switched to a new branch 'test' 3d14890 hd-geo-test: Add tests for lchs override 8db970f bootdevice: FW_CFG interface for LCHS values f73e65a8 bootdevice: Refactor get_boot_devices_list d1d97ec bootdevice: Gather LCHS from all relevant devices 31221f5 scsi: Propagate unrealize() callback to scsi-hd 6422c6a bootdevice: Add interface to gather LCHS b2360f7 block: Support providing LCHS from user 1c43be6 block: Refactor macros - fix tabbing === OUTPUT BEGIN === 1/8 Checking commit 1c43be6de15d (block: Refactor macros - fix tabbing) ERROR: Macros with complex values should be enclosed in parenthesis #55: FILE: include/hw/block/block.h:65: +#define DEFINE_BLOCK_CHS_PROPERTIES(_state, _conf) \ + DEFINE_PROP_UINT32("cyls", _state, _conf.cyls, 0), \ + DEFINE_PROP_UINT32("heads", _state, _conf.heads, 0), \ DEFINE_PROP_UINT32("secs", _state, _conf.secs, 0) total: 1 errors, 0 warnings, 37 lines checked Patch 1/8 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 2/8 Checking commit b2360f718807 (block: Support providing LCHS from user) 3/8 Checking commit 6422c6acc42a (bootdevice: Add interface to gather LCHS) 4/8 Checking commit 31221f5a0d4d (scsi: Propagate unrealize() callback to scsi-hd) 5/8 Checking commit d1d97eca7de2 (bootdevice: Gather LCHS from all relevant devices) 6/8 Checking commit f73e65a879c8 (bootdevice: Refactor get_boot_devices_list) 7/8 Checking commit 8db970f739ad (bootdevice: FW_CFG interface for LCHS values) 8/8 Checking commit 3d148902136a (hd-geo-test: Add tests for lchs override) WARNING: Block comments use a leading /* on a separate line #648: FILE: tests/hd-geo-test.c:1003: + "skipping hd-geo/override/* tests"); total: 0 errors, 1 warnings, 616 lines checked Patch 8/8 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20190925110639.100699-1-sam...@google.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com
