11.09.2019 15:08, Vladimir Sementsov-Ogievskiy wrote: > 10.09.2019 16:59, Eric Blake wrote: >> On 9/10/19 3:03 AM, Daniel P. Berrangé wrote: >>> On Tue, Sep 10, 2019 at 10:59:43AM +0300, Vladimir Sementsov-Ogievskiy >>> wrote: >>>> In "if (saddr->keep_alive) {" we may already be on error path, with >>>> invalid sock < 0. Fix it by returning error earlier. >>>> >>>> Reported-by: Coverity (CID 1405300) >>>> Suggested-by: Peter Maydell <peter.mayd...@linaro.org> >>>> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsement...@virtuozzo.com> >>>> --- >>>> util/qemu-sockets.c | 5 +++-- >>>> 1 file changed, 3 insertions(+), 2 deletions(-) >>> >>> Reviewed-by: Daniel P. Berrangé <berra...@redhat.com> >> >> Thanks. Will queue through my NBD tree, since that's where the original >> problem was introduced. >> > > Please add when queueing: > > Fixes: aec21d31756cbd >
Hmm, don't you forget? Don't see it neither in pull request nor in your branches. -- Best regards, Vladimir