On Fri, Sep 27, 2019 at 12:50:55AM +0100, Alex Bennée wrote: > > Richard Henderson <richard.hender...@linaro.org> writes: > > > On 9/24/19 4:31 AM, Andrew Jones wrote: > <snip> > > > >> +#if __SIZEOF_LONG__ == 8 > >> +#define BIT(n) (1UL << (n)) > >> +#else > >> +#define BIT(n) (1ULL << (n)) > >> +#endif > > > > There's no reason not to always use 1ULL is there? > > Also we already have this helper in bitops.h so should just use that.
bitops.h BIT() uses UL, but we need ULL. FWIW, the kernel has a BIT_ULL() that we could mimic in QEMU. I guess I could even add that for this patch, if you'd like. Thanks, drew
