On 9/25/19 1:37 PM, Mark Cave-Ayland wrote: > I see now that you've given R-b tags for patches 3-7, and having slept on it > I'm > inclined to leave patches 1-2 as they are now, i.e. no code changes other than > introducing the get/set helpers to help keep the patchset as mechanical as > possible. > Do you think that seems a reasonable approach?
Yes, I should have gone back and given you r-b for patches 1 & 2 as well. Have those now: Reviewed-by: Richard Henderson <richard.hender...@linaro.org> > Certainly ppc_vsr_t already has __uint128_t and Int128 elements but the > impression I > got from the #ifdef is that not all compilers would support it? Although > having said > that, making such a change is not something that's really on my radar. Int128 is usable everywhere. It's just the implementation under the hood that changes depending on the compiler. r~
