Richard Henderson <richard.hender...@linaro.org> writes:
> We can use notdirty_write for the write and
> return a valid host pointer for this case.
nit: reflow the text
>
> Signed-off-by: Richard Henderson <richard.hender...@linaro.org>
> ---
> accel/tcg/cputlb.c | 26 +++++++++++++++++---------
> 1 file changed, 17 insertions(+), 9 deletions(-)
>
> diff --git a/accel/tcg/cputlb.c b/accel/tcg/cputlb.c
> index 09b0df87c6..d0bdef1eb3 100644
> --- a/accel/tcg/cputlb.c
> +++ b/accel/tcg/cputlb.c
> @@ -1167,16 +1167,24 @@ void *probe_access(CPUArchState *env, target_ulong
> addr, int size,
> return NULL;
> }
>
> - /* Handle watchpoints. */
> - if (tlb_addr & TLB_WATCHPOINT) {
> - cpu_check_watchpoint(env_cpu(env), addr, size,
> - env_tlb(env)->d[mmu_idx].iotlb[index].attrs,
> - wp_access, retaddr);
> - }
> + if (unlikely(tlb_addr & TLB_FLAGS_MASK)) {
> + CPUIOTLBEntry *iotlbentry =
> &env_tlb(env)->d[mmu_idx].iotlb[index];
I was going to say we compute this early but I'm assuming the compiler
can figure that out if it needs to.
Reviewed-by: Alex Bennée <alex.ben...@linaro.org>
--
Alex Bennée
