Patchew URL: https://patchew.org/QEMU/20190912060701.4642-1-ys...@users.sourceforge.jp/
Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH v24 00/22] Add RX archtecture support Message-id: 20190912060701.4642-1-ys...@users.sourceforge.jp Type: series === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === From https://github.com/patchew-project/qemu - [tag update] patchew/20190912060701.4642-1-ys...@users.sourceforge.jp -> patchew/20190912060701.4642-1-ys...@users.sourceforge.jp Switched to a new branch 'test' b344509 qapi/machine.json: Add RX cpu. dbc4316 BootLinuxConsoleTest: Test the RX-Virt machine a73dba4 Add rx-softmmu 9e326f2 hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core 0e20757 hw/rx: Honor -accel qtest b8ef978 hw/rx: RX Target hardware definition a6e9525 hw/char: RX62N serial communication interface (SCI) 523f6ae hw/timer: RX62N internal timer modules dd7c03a hw/intc: RX62N interrupt controller (ICUa) 034ef9c target/rx: Dump bytes for each insn during disassembly 4a9f231 target/rx: Collect all bytes during disassembly 52ea55b target/rx: Emit all disassembly in one prt() c6a6fa3 target/rx: Use prt_ldmi for XCHG_mr disassembly 9d2d4c2 target/rx: Replace operand with prt_ldmi in disassembler 9409eea target/rx: Disassemble rx_index_addr into a string 24a6ce3 target/rx: RX disassembler 4324951 target/rx: CPU definition e013cf2 target/rx: TCG helper 2f5906e target/rx: TCG translation bd2b801 hw/registerfields.h: Add 8bit and 16bit register macros ffecfbc qemu/bitops.h: Add extract8 and extract16 08c4e97 MAINTAINERS: Add RX === OUTPUT BEGIN === 1/22 Checking commit 08c4e975d29f (MAINTAINERS: Add RX) 2/22 Checking commit ffecfbc89a8c (qemu/bitops.h: Add extract8 and extract16) 3/22 Checking commit bd2b8012f2e5 (hw/registerfields.h: Add 8bit and 16bit register macros) Use of uninitialized value in concatenation (.) or string at ./scripts/checkpatch.pl line 2484. ERROR: Macros with multiple statements should be enclosed in a do - while loop #27: FILE: include/hw/registerfields.h:25: +#define REG8(reg, addr) \ + enum { A_ ## reg = (addr) }; \ + enum { R_ ## reg = (addr) }; ERROR: Macros with multiple statements should be enclosed in a do - while loop #31: FILE: include/hw/registerfields.h:29: +#define REG16(reg, addr) \ + enum { A_ ## reg = (addr) }; \ + enum { R_ ## reg = (addr) / 2 }; total: 2 errors, 0 warnings, 56 lines checked Patch 3/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 4/22 Checking commit 2f5906ec35fa (target/rx: TCG translation) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #20: new file mode 100644 total: 0 errors, 1 warnings, 3065 lines checked Patch 4/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 5/22 Checking commit e013cf2e29f7 (target/rx: TCG helper) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #21: new file mode 100644 total: 0 errors, 1 warnings, 650 lines checked Patch 5/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 6/22 Checking commit 432495109747 (target/rx: CPU definition) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #39: new file mode 100644 total: 0 errors, 1 warnings, 588 lines checked Patch 6/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 7/22 Checking commit 24a6ce386bc6 (target/rx: RX disassembler) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #38: new file mode 100644 total: 0 errors, 1 warnings, 1497 lines checked Patch 7/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 8/22 Checking commit 9409eeafa61d (target/rx: Disassemble rx_index_addr into a string) 9/22 Checking commit 9d2d4c2a3f48 (target/rx: Replace operand with prt_ldmi in disassembler) 10/22 Checking commit c6a6fa3f837f (target/rx: Use prt_ldmi for XCHG_mr disassembly) 11/22 Checking commit 52ea55be5ba4 (target/rx: Emit all disassembly in one prt()) 12/22 Checking commit 4a9f231d6170 (target/rx: Collect all bytes during disassembly) 13/22 Checking commit 034ef9cc868c (target/rx: Dump bytes for each insn during disassembly) 14/22 Checking commit dd7c03aa119a (hw/intc: RX62N interrupt controller (ICUa)) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #40: new file mode 100644 total: 0 errors, 1 warnings, 445 lines checked Patch 14/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 15/22 Checking commit 523f6ae3c8eb (hw/timer: RX62N internal timer modules) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #50: new file mode 100644 total: 0 errors, 1 warnings, 845 lines checked Patch 15/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 16/22 Checking commit a6e952569108 (hw/char: RX62N serial communication interface (SCI)) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #43: new file mode 100644 total: 0 errors, 1 warnings, 401 lines checked Patch 16/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 17/22 Checking commit b8ef9788960c (hw/rx: RX Target hardware definition) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #29: new file mode 100644 total: 0 errors, 1 warnings, 480 lines checked Patch 17/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 18/22 Checking commit 0e207577f922 (hw/rx: Honor -accel qtest) 19/22 Checking commit 9e326f205701 (hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core) 20/22 Checking commit a73dba432bb2 (Add rx-softmmu) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #59: new file mode 100644 total: 0 errors, 1 warnings, 59 lines checked Patch 20/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 21/22 Checking commit dbc431623329 (BootLinuxConsoleTest: Test the RX-Virt machine) 22/22 Checking commit b344509cdbc8 (qapi/machine.json: Add RX cpu.) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20190912060701.4642-1-ys...@users.sourceforge.jp/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com