Re: [Qemu-devel] [PATCH 2/3] cputlb: Replace switches in load/store_helper with callback

[Richard Henderson]

On 9/11/19 9:07 AM, Philippe Mathieu-Daudé wrote:
>>  {
>>      return load_helper(env, addr, oi, retaddr, MO_LEUW, false,
>> -                       full_le_lduw_mmu);
>> +                       full_le_lduw_mmu, direct_lduw_le);
> 
> Why not cast lduw_be_p? (except for direct_ldub).
> 
>       return load_helper(env, addr, oi, retaddr, MO_LEUW, false,
>                        full_le_lduw_mmu, (DirectLoadHelper)lduw_be_p);
> 
> Useful to set breakpoint while debugging?

Because the types in the function signature are different,
and such a cast will cause misbehavior.


r~