On Sat, Aug 31, 2019 at 11:52:47PM +0800, Li Qiang wrote: > <no-re...@patchew.org> 于2019年8月31日周六 下午11:46写道： > > > Patchew URL: > > https://patchew.org/QEMU/20190831153922.121308-1-liq...@163.com/ > > > > > > > > Hi, > > > > This series seems to have some coding style problems. See output below for > > more information: > > > > Type: series > > Message-id: 20190831153922.121308-1-liq...@163.com > > Subject: [Qemu-devel] [PATCH] vnc: fix memory leak when vnc disconnect > > > > === TEST SCRIPT BEGIN === > > #!/bin/bash > > git rev-parse base > /dev/null || exit 0 > > git config --local diff.renamelimit 0 > > git config --local diff.renames True > > git config --local diff.algorithm histogram > > ./scripts/checkpatch.pl --mailback base.. > > === TEST SCRIPT END === > > > > Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 > > Switched to a new branch 'test' > > fb52b49 vnc: fix memory leak when vnc disconnect > > > > === OUTPUT BEGIN === > > ERROR: spaces required around that '*' (ctx:WxB) > > #118: FILE: ui/vnc-enc-tight.c:355: > > + data = (uint##bpp##_t *)vs->tight->tight.buffer; \ > > ^ > > > > > > Hello Paolo and the Checkpatch maintainers, > > I also see this error in scripts/checkpatch.pl. > However when I add sapces around '*". I got following error: > > ERROR: space prohibited before that close parenthesis ')' > > #124: FILE: ui/vnc-enc-tight.c:355: > > + data = (uint##bpp##_t * )vs->tight->tight.buffer; \ > > > > So I'm confused how to make checkpatch.pl happy. > > > Any one has suggests? Or we need a patch for checkpatch.pl?
Either ignore this patch warning, or figure out how to fix checkpatch.pl though the latter quite be quite hard Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
