On 02/09/19 11:02, Daniel P. Berrangé wrote: >>> === OUTPUT BEGIN === >>> ERROR: spaces required around that '*' (ctx:WxB) >>> #118: FILE: ui/vnc-enc-tight.c:355: >>> + data = (uint##bpp##_t *)vs->tight->tight.buffer; \ >>> ^ >>> >>> >> Hello Paolo and the Checkpatch maintainers, >> >> I also see this error in scripts/checkpatch.pl. >> However when I add sapces around '*". I got following error: >> >> ERROR: space prohibited before that close parenthesis ')' >> >> #124: FILE: ui/vnc-enc-tight.c:355: >> >> + data = (uint##bpp##_t * )vs->tight->tight.buffer; \ >> >> >> >> So I'm confused how to make checkpatch.pl happy. >> >> >> Any one has suggests? Or we need a patch for checkpatch.pl? > Either ignore this patch warning, or figure out how to fix > checkpatch.pl though the latter quite be quite hard
checkpatch is confuesd by ##. It's probably possible to do something like commit e20122ff0faf07cb701d35e39e106d1783c07725 to fix it, but your patch is okay without the space after "*". Paolo
