On 13/07/19 19:46, Stefan Weil wrote: > > LGTM reports 16 errors, 81 warnings and 119 recommendations: > https://lgtm.com/projects/g/qemu/qemu/alerts/?mode=list. > > Some of them are already know (wrong format strings), others look like > real errors: > > - several multiplication results which don't work as they should in > contrib/vhost-user-gpu, block/* (m->nb_clusters * s->cluster_size only > 32 bit!), target/i386/translate.c and other files
m->nb_clusters here is limited by s->l2_slice_size (see for example handle_alloc) so I wouldn't be surprised if this is a false positive. I couldn't find this particular multiplication in Coverity, but it has about 250 issues marked as intentional or false positive so there's probably a lot of overlap with what LGTM found. Paolo
