Patchew URL: https://patchew.org/QEMU/20190702121106.28374-1-...@redhat.com/
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Subject: [Qemu-devel] [PATCH v3 0/4] Introduce the microvm machine type Message-id: 20190702121106.28374-1-...@redhat.com === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu - [tag update] patchew/20190702113414.6896-1-arm...@redhat.com -> patchew/20190702113414.6896-1-arm...@redhat.com Switched to a new branch 'test' 8ebe540 hw/i386: Introduce the microvm machine type ac71c2a hw/i386: Factorize PVH related functions faeccbd hw/i386: Add an Intel MPTable generator 7540b93 hw/virtio: Factorize virtio-mmio headers === OUTPUT BEGIN === 1/4 Checking commit 7540b9358a0f (hw/virtio: Factorize virtio-mmio headers) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #66: new file mode 100644 total: 0 errors, 1 warnings, 105 lines checked Patch 1/4 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 2/4 Checking commit faeccbd2c589 (hw/i386: Add an Intel MPTable generator) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #16: new file mode 100644 total: 0 errors, 1 warnings, 374 lines checked Patch 2/4 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 3/4 Checking commit ac71c2af3972 (hw/i386: Factorize PVH related functions) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #186: new file mode 100644 ERROR: do not initialise statics to 0 or NULL #210: FILE: hw/i386/pvh.c:20: +static size_t pvh_start_addr = 0; total: 1 errors, 1 warnings, 281 lines checked Patch 3/4 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 4/4 Checking commit 8ebe540c4430 (hw/i386: Introduce the microvm machine type) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #67: new file mode 100644 ERROR: Error messages should not contain newlines #291: FILE: hw/i386/microvm.c:220: + error_report("qemu: error reading initrd %s: %s\n", ERROR: Error messages should not contain newlines #299: FILE: hw/i386/microvm.c:228: + "(max: %"PRIu32", need %"PRId64")\n", total: 2 errors, 1 warnings, 653 lines checked Patch 4/4 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20190702121106.28374-1-...@redhat.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com