Hi,

> +#define MICROVM_MAX_BELOW_4G  0xe0000000
> +
> +/* Platform virtio definitions */
> +#define VIRTIO_MMIO_BASE      0xd0000000

That isn't going to fly ...

I'd also suggest to add a microvm.txt file to docs/ with specification
(io memory, io ports, memory layout in pvh mode, in firmware mode, ...)
and usage information.

cut & paste the bits sprinkled all over in commit messages and cover
letter would be a good start.

cheers,
  Gerd


Reply via email to