On Sun, 30 Jun 2019 at 11:21, Hongbo Zhang <hongbo.zh...@linaro.org> wrote: > > For the Aarch64, there is one machine 'virt', it is primarily meant to > run on KVM and execute virtualization workloads, but we need an > environment as faithful as possible to physical hardware, to support > firmware and OS development for pysical Aarch64 machines. > > This machine comes with: > - Re-designed memory map. > - CPU cortex-a57. > - EL2 and EL3 enabled. > - GIC version 3. > - System bus AHCI controller. > - System bus XHCI controller. > - CDROM and hard disc on AHCI bus. > - E1000E ethernet card on PCIE bus. > - VGA display adaptor on PCIE bus. > - Only minimal device tree nodes. > And without: > - virtio deivces. > - fw_cfg device. > - ACPI tables.
I've pointed out a number of issues with these patches, but they all turn out to be very minor (mostly fixable by moving code between patch 1 and 2). The other thing we need is a MAINTAINERS section for the new board: diff --git a/MAINTAINERS b/MAINTAINERS index cad58b94879..0bf3739f06a 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -728,6 +728,13 @@ F: include/hw/arm/fsl-imx6.h F: include/hw/misc/imx6_*.h F: include/hw/ssi/imx_spi.h +SBSA-REF +M: Hongbo Zhang <hongbo.zh...@linaro.org> +M: Peter Maydell <peter.mayd...@linaro.org> +L: qemu-...@nongnu.org +S: Maintained +F: hw/arm/sbsa-ref.c + Sharp SL-5500 (Collie) PDA M: Peter Maydell <peter.mayd...@linaro.org> L: qemu-...@nongnu.org So rather than making you do another respin, I'm planning to make the fixes in my target-arm.next tree as I apply the patches. That way we can get this in before softfreeze (which is tomorrow). thanks -- PMM