Please redirect to the V2 RESEND patch, this one not rebased on upstream code.
Thanks
Zhang Chen
> -----Original Message-----
> From: Zhang, Chen
> Sent: Friday, June 21, 2019 1:52 PM
> To: Xie Changlong <xiechanglon...@gmail.com>; Kevin Wolf
> <kw...@redhat.com>; Max Reitz <mre...@redhat.com>; qemu-block <qemu-
> bl...@nongnu.org>; qemu-dev <qemu-devel@nongnu.org>
> Cc: Zhang Chen <zhangc...@gmail.com>; Zhang, Chen <chen.zh...@intel.com>
> Subject: [PATCH V2] block/replication.c: Fix crash issue after failover
>
> From: Zhang Chen <chen.zh...@intel.com>
>
> If we try to close replication after failover, it will crash here.
> So we need check the block job on active disk before cancel the job.
>
> Signed-off-by: Zhang Chen <chen.zh...@intel.com>
> ---
> block/replication.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/block/replication.c b/block/replication.c index
> 3d4dedddfc..845f796dd4 100644
> --- a/block/replication.c
> +++ b/block/replication.c
> @@ -146,7 +146,9 @@ static void replication_close(BlockDriverState *bs)
> replication_stop(s->rs, false, NULL);
> }
> if (s->stage == BLOCK_REPLICATION_FAILOVER) {
> - job_cancel_sync(&s->active_disk->bs->job->job);
> + if (s->active_disk->bs->job) {
> + job_cancel_sync(&s->active_disk->bs->job->job);
> + }
> }
>
> if (s->mode == REPLICATION_MODE_SECONDARY) {
> --
> 2.17.GIT
