QEMU’s always been confused over what a snapshot is: Is it the overlay? Is it the backing image?
Confusion is rarely a good thing. I can’t think of any objective reason why the overlay would be a snapshot. A snapshot is something that does not change over time; the overlay does. (I suppose historically the reason is that “Taking an overlay” makes no sense, so the operations are called “Taking a snapshot”. Somehow, this meaning carried over to the new file that is created during that operation; if “Creating a snapshot” creates a file, that file must be the snapshot, right? Well, no, it isn’t.) Let’s fix this as best as we can. Better Nate than lever. Mae Reitz (2): qapi/block-core: Overlays are not snapshots blockdev: Overlays are not snapshots qapi/block-core.json | 20 ++++++++++---------- blockdev.c | 10 +++++----- 2 files changed, 15 insertions(+), 15 deletions(-) -- 2.21.0
