> On Sunday, May 26, 2019, 4:45:26 PM GMT+9, <no-re...@patchew.org> wrote: > Subject; [Qemu-devel] [PATCH] Incorrect Stack Pointer shadow register support on some m68k CPUs > .....> snip> .....> === OUTPUT BEGIN === > ERROR: Author email address is mangled by the mailing list > #2: > Author: Lucien Murray-Pitts via Qemu-devel <qemu-devel@nongnu.org> > > WARNING: Block comments use a leading /* on a separate line > #46: FILE: target/m68k/cpu.h:465: > +/* The ColdFire core ISA is a RISC-style reduction of the 68000 series > > WARNING: Block comments use * on subsequent lines > #47: FILE: target/m68k/cpu.h:466:> > +/* The ColdFire core ISA is a RISC-style reduction of the 68000 series > + Whilst the 68000 flourished by adding extended stack/instructions > in>.........> snip Q1: Name mangling seems to be a bug, whats going on - how should I be submiting now? ( perl script didnt catch it AND there seems to already be a patch from half year or more ago .. https://patchwork.kernel.org/patch/10662525/ ) whats the correct action here? Q2: I am getting a WARNING but I believe it is an exception in this case. yes I know it breaks the coding style BUT this coding style was already there for these comments. Should I submit this patch with a move to the RIGHT coding style? or will this patch be accepted as the code is older style?
[Qemu-devel] Failure to submit patches, two questions - what should I do?
Lucien Anti-Spam via Qemu-devel Sun, 26 May 2019 01:34:54 -0700
- [Qemu-devel] Failure to submit patches, tw... Lucien Anti-Spam via Qemu-devel
- Re: [Qemu-devel] Failure to submit pa... Thomas Huth
- Re: [Qemu-devel] Failure to submi... Laurent Vivier