On 5/21/19 7:51 PM, Aarushi Mehta wrote:
>>> +# @io_uring: Use linux io_uring
>>
>> Missing a '(since 4.1)' tag.
>>
>>> #
>>> # Since: 2.9
>>> ##
>>> { 'enum': 'BlockdevAioOptions',
>>> - 'data': [ 'threads', 'native' ] }
>>> + 'data': [ 'threads', 'native','io_uring' ] }
>>
>> Missing space after ',' (not essential, but matching style is nice).
>> Should the new element be defined conditionally, so that
>> introspection
>> only sees the new enum member when compiled for Linux?
>>
> I'm not sure what would be the benefits of that? We already check for
> Linux at configure, and this would reduce readability. We aren't doing
> this for native.Look at BlockdevOptionsFile in qapi/block-core.qapi. Telling the QAPI generator that something is only available on Linux means that it will be obvious to introspection (the QMP command query-qmp-schema) whether the feature is present in a particular binary. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
