On 4/29/19 8:00 AM, Peter Maydell wrote: > On Thu, 28 Mar 2019 at 23:23, Richard Henderson > <richard.hender...@linaro.org> wrote: >> >> Signed-off-by: Richard Henderson <richard.hender...@linaro.org> >> --- >> tcg/arm/tcg-target.inc.c | 109 +++++++++++++++++++-------------------- >> 1 file changed, 52 insertions(+), 57 deletions(-) > > I think this would be easier to understand if the commit message > included what the old and new generated code fragments looked like.
Fair enough. This change is complicated by having to rearrange register usage, so that we ldrd into r0+r1 instead of ldr into r1+r2, etc. Just this once it would have been easier in thumb2. ;-) > The same remark about a compile-time check that mask and > table are where we expect from patch 35 applies here too. Ok. r~
