On Thu, 28 Mar 2019 at 23:23, Richard Henderson <richard.hender...@linaro.org> wrote: > > Signed-off-by: Richard Henderson <richard.hender...@linaro.org> > --- > tcg/arm/tcg-target.inc.c | 109 +++++++++++++++++++-------------------- > 1 file changed, 52 insertions(+), 57 deletions(-)
I think this would be easier to understand if the commit message included what the old and new generated code fragments looked like. (git diff seems to not have done a very good job of identifying what's actually changed in this patch, unfortunately.) The same remark about a compile-time check that mask and table are where we expect from patch 35 applies here too. thanks -- PMM