On Tue, Apr 16, 2019 at 11:59:42PM -0300, Eduardo Habkost wrote: > The return value of cpu_get_model() is just a CPU model name and > never includes extra options. We don't need to call > parse_cpu_option().
Oops. I was wrong. linux-user also supports extra features in the "-cpu" option, so we do need to call parse_cpu_option(). e.g.: this worked before: $ qemu-x86_64 -cpu Nehalem,+popcnt /bin/true and now this is broken: $ qemu-x86_64 -cpu Nehalem,+popcnt /bin/true unable to find CPU model 'Nehalem,+popcnt' I will drop patches 2-5 from my queue. Sorry for the noise. -- Eduardo
