On Tue, Apr 09, 2019 at 01:25:43PM +0200, Marc-André Lureau wrote: > Hi > > On Tue, Apr 9, 2019 at 12:40 PM Philippe Mathieu-Daudé > <phi...@redhat.com> wrote: > > > > On 4/8/19 2:31 PM, Markus Armbruster wrote: > > > Marc-André Lureau <marcandre.lur...@redhat.com> writes: > > > > > >> Hi > > >> > > >> On Mon, Apr 8, 2019 at 10:36 AM Markus Armbruster <arm...@redhat.com> > > >> wrote: > > >>> > > >>> char_pty_open() prints a "char device redirected to PTY_NAME (label > > >>> LABEL)" message to the current monitor or else to stderr. No other > > >>> ChardevClass::open() prints anything on success. Drop the message. > > >>> > > >>> Cc: "Marc-André Lureau" <marcandre.lur...@redhat.com> > > >>> Cc: Paolo Bonzini <pbonz...@redhat.com> > > >>> Signed-off-by: Markus Armbruster <arm...@redhat.com> > > >>> --- > > >>> chardev/char-pty.c | 2 -- > > >>> 1 file changed, 2 deletions(-) > > >>> > > >> > > >> I guess that was printed for convenience. > > >> > > >> Allocated pty can be read from "info chardev", so I suppose we can > > >> make qemu more silent. Fine with me: > > >> > > >> Reviewed-by: Marc-André Lureau <marcandre.lur...@redhat.com> > > > > > > Thanks! > > > > > > If we should decide the message is still useful enough to be worth > > > keeping, I could direct it to stdout instead of dropping it. > > > > I prefer this, if Marc-André is still OK. > > I don't mind, but I wonder if we really have users that care. Power > users can easily get the associated pty from a monitor query.
IMHO if people want predictable filenames for chardevs without needing to lookup the name via the monitor, then UNIX sockets fill that need. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
