On 3/20/19 5:09 PM, Aleksandar Markovic wrote: > This patch is really large.How about splitting it into a dozen of smaller > logical groups? Also, a successful build (both gcc and clang kinds) is > required after each patch.
Successful builds are often not feasible for new ports, since most often the actual enable of the port is the very last patch, as it (nearly) is here -- patch 10/12. But you're right that smaller patches are easier to review. r~