On Mon, Mar 11, 2019 at 12:49:50PM +0100, Thomas Huth wrote: > On 08/03/2019 17.11, Philippe Mathieu-Daudé wrote: > > Hi Markus, > > > > [Asking again from the correct series thread] > > > > On 1/3/18 10:49 PM, Philippe Mathieu-Daudé wrote: > >> Use Base64 to serialize the binary blobs in JSON. > >> So far at most 512 bytes will be transfered, which result > >> in a 684 bytes payload. > >> Since this command is intented for qtesting, it is acceptable. > > > > Any comment regarding QMP for this patch? > > Is this useful for anybody else than qtest? If not, I think this should > rather go into the qtest protocol instead, since QMP is our "public" > protocol.
Extending qtest requires writing parsers by hand. Do we really want to go that route and start extending the qtest protocol more often? I also plan to add new debugging-only QMP commands for testing CPU code, and I'm not looking forward to writing my own parser inside qtest_process_command(). -- Eduardo
