Patchew URL: https://patchew.org/QEMU/20190308202858.26636-1-js...@redhat.com/
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20190308202858.26636-1-js...@redhat.com Subject: [Qemu-devel] [PULL 00/17] Bitmaps patches === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu t [tag update] patchew/20190308202858.26636-1-js...@redhat.com -> patchew/20190308202858.26636-1-js...@redhat.com Switched to a new branch 'test' 3d5e719ca4 block/dirty-bitmaps: implement inconsistent bit 465831cd59 block/dirty-bitmaps: disallow busy bitmaps as merge source 31780545dd block/dirty-bitmaps: prohibit removing readonly bitmaps 7559e374a2 block/dirty-bitmaps: prohibit readonly bitmaps for backups aa7d65f2c7 block/dirty-bitmaps: add block_dirty_bitmap_check function c680f34e1a block/dirty-bitmap: add inconsistent status 144ff09b4a block/dirty-bitmaps: add inconsistent bit 3404fb4d3c iotests: add busy/recording bit test to 124 c1abe84ba0 blockdev: remove unused paio parameter documentation a9cea08dae block/dirty-bitmaps: move comment block 0c7cb0afda block/dirty-bitmaps: unify qmp_locked and user_locked calls 0978398f68 block/dirty-bitmap: explicitly lock bitmaps with successors 359bac67ac nbd: change error checking order for bitmaps 03ca272dcf block/dirty-bitmap: change semantics of enabled predicate 39788c7010 block/dirty-bitmap: remove set/reset assertions against enabled bit 953dca788e block/dirty-bitmaps: rename frozen predicate helper ad226cd02f block/dirty-bitmap: add recording and busy properties === OUTPUT BEGIN === 1/17 Checking commit ad226cd02f0d (block/dirty-bitmap: add recording and busy properties) 2/17 Checking commit 953dca788e01 (block/dirty-bitmaps: rename frozen predicate helper) WARNING: line over 80 characters #87: FILE: block/dirty-bitmap.c:248: + error_setg(errp, "Cannot create a successor for a bitmap that is in-use " total: 0 errors, 1 warnings, 124 lines checked Patch 2/17 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 3/17 Checking commit 39788c7010d2 (block/dirty-bitmap: remove set/reset assertions against enabled bit) 4/17 Checking commit 03ca272dcfe2 (block/dirty-bitmap: change semantics of enabled predicate) 5/17 Checking commit 359bac67ac40 (nbd: change error checking order for bitmaps) 6/17 Checking commit 0978398f6879 (block/dirty-bitmap: explicitly lock bitmaps with successors) 7/17 Checking commit 0c7cb0afdaff (block/dirty-bitmaps: unify qmp_locked and user_locked calls) ERROR: open brace '{' following function declarations go on the next line #39: FILE: block/dirty-bitmap.c:190: +bool bdrv_dirty_bitmap_busy(BdrvDirtyBitmap *bitmap) { total: 1 errors, 0 warnings, 271 lines checked Patch 7/17 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 8/17 Checking commit a9cea08daeed (block/dirty-bitmaps: move comment block) 9/17 Checking commit c1abe84ba004 (blockdev: remove unused paio parameter documentation) 10/17 Checking commit 3404fb4d3ca7 (iotests: add busy/recording bit test to 124) 11/17 Checking commit 144ff09b4a7c (block/dirty-bitmaps: add inconsistent bit) WARNING: Block comments use a leading /* on a separate line #26: FILE: block/dirty-bitmap.c:49: + bool inconsistent; /* bitmap is persistent, but inconsistent. WARNING: Block comments use a trailing */ on a separate line #28: FILE: block/dirty-bitmap.c:51: + * a QMP user can remove it. */ total: 0 errors, 2 warnings, 82 lines checked Patch 11/17 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 12/17 Checking commit c680f34e1af5 (block/dirty-bitmap: add inconsistent status) 13/17 Checking commit aa7d65f2c71f (block/dirty-bitmaps: add block_dirty_bitmap_check function) ERROR: open brace '{' following function declarations go on the next line #37: FILE: block/dirty-bitmap.c:177: +static bool bdrv_dirty_bitmap_busy(const BdrvDirtyBitmap *bitmap) { WARNING: line over 80 characters #284: FILE: migration/block-dirty-bitmap.c:305: + if (bdrv_dirty_bitmap_check(bitmap, BDRV_BITMAP_DEFAULT, &local_err)) { total: 1 errors, 1 warnings, 236 lines checked Patch 13/17 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 14/17 Checking commit 7559e374a22f (block/dirty-bitmaps: prohibit readonly bitmaps for backups) 15/17 Checking commit 31780545dd08 (block/dirty-bitmaps: prohibit removing readonly bitmaps) 16/17 Checking commit 465831cd595f (block/dirty-bitmaps: disallow busy bitmaps as merge source) 17/17 Checking commit 3d5e719ca44a (block/dirty-bitmaps: implement inconsistent bit) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20190308202858.26636-1-js...@redhat.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-de...@redhat.com
