Patchew URL: https://patchew.org/QEMU/20190308202858.26636-1-js...@redhat.com/
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20190308202858.26636-1-js...@redhat.com Subject: [Qemu-devel] [PULL 00/17] Bitmaps patches === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu * [new tag] patchew/20190308202858.26636-1-js...@redhat.com -> patchew/20190308202858.26636-1-js...@redhat.com Switched to a new branch 'test' 6a083e7a44 block/dirty-bitmaps: implement inconsistent bit f00e672dd7 block/dirty-bitmaps: disallow busy bitmaps as merge source ca8fdb5e18 block/dirty-bitmaps: prohibit removing readonly bitmaps 4085064d76 block/dirty-bitmaps: prohibit readonly bitmaps for backups 46e4307e40 block/dirty-bitmaps: add block_dirty_bitmap_check function e0e53b95d2 block/dirty-bitmap: add inconsistent status 061152794d block/dirty-bitmaps: add inconsistent bit 20eb6ea4b5 iotests: add busy/recording bit test to 124 f0dea169fe blockdev: remove unused paio parameter documentation 5b090a904b block/dirty-bitmaps: move comment block 235c618265 block/dirty-bitmaps: unify qmp_locked and user_locked calls 9cd31200c1 block/dirty-bitmap: explicitly lock bitmaps with successors 0260a9c1c5 nbd: change error checking order for bitmaps 80fbc5114e block/dirty-bitmap: change semantics of enabled predicate 62a0dda136 block/dirty-bitmap: remove set/reset assertions against enabled bit 4d10356687 block/dirty-bitmaps: rename frozen predicate helper 8e21a1f266 block/dirty-bitmap: add recording and busy properties === OUTPUT BEGIN === 1/17 Checking commit 8e21a1f266ae (block/dirty-bitmap: add recording and busy properties) 2/17 Checking commit 4d10356687c2 (block/dirty-bitmaps: rename frozen predicate helper) WARNING: line over 80 characters #87: FILE: block/dirty-bitmap.c:248: + error_setg(errp, "Cannot create a successor for a bitmap that is in-use " total: 0 errors, 1 warnings, 124 lines checked Patch 2/17 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 3/17 Checking commit 62a0dda1369b (block/dirty-bitmap: remove set/reset assertions against enabled bit) 4/17 Checking commit 80fbc5114eb1 (block/dirty-bitmap: change semantics of enabled predicate) 5/17 Checking commit 0260a9c1c566 (nbd: change error checking order for bitmaps) 6/17 Checking commit 9cd31200c142 (block/dirty-bitmap: explicitly lock bitmaps with successors) 7/17 Checking commit 235c61826568 (block/dirty-bitmaps: unify qmp_locked and user_locked calls) ERROR: open brace '{' following function declarations go on the next line #39: FILE: block/dirty-bitmap.c:190: +bool bdrv_dirty_bitmap_busy(BdrvDirtyBitmap *bitmap) { total: 1 errors, 0 warnings, 271 lines checked Patch 7/17 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 8/17 Checking commit 5b090a904b91 (block/dirty-bitmaps: move comment block) 9/17 Checking commit f0dea169fe5e (blockdev: remove unused paio parameter documentation) 10/17 Checking commit 20eb6ea4b57a (iotests: add busy/recording bit test to 124) 11/17 Checking commit 061152794d63 (block/dirty-bitmaps: add inconsistent bit) WARNING: Block comments use a leading /* on a separate line #26: FILE: block/dirty-bitmap.c:49: + bool inconsistent; /* bitmap is persistent, but inconsistent. WARNING: Block comments use a trailing */ on a separate line #28: FILE: block/dirty-bitmap.c:51: + * a QMP user can remove it. */ total: 0 errors, 2 warnings, 82 lines checked Patch 11/17 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 12/17 Checking commit e0e53b95d21c (block/dirty-bitmap: add inconsistent status) 13/17 Checking commit 46e4307e401e (block/dirty-bitmaps: add block_dirty_bitmap_check function) ERROR: open brace '{' following function declarations go on the next line #37: FILE: block/dirty-bitmap.c:177: +static bool bdrv_dirty_bitmap_busy(const BdrvDirtyBitmap *bitmap) { WARNING: line over 80 characters #284: FILE: migration/block-dirty-bitmap.c:305: + if (bdrv_dirty_bitmap_check(bitmap, BDRV_BITMAP_DEFAULT, &local_err)) { total: 1 errors, 1 warnings, 236 lines checked Patch 13/17 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 14/17 Checking commit 4085064d763d (block/dirty-bitmaps: prohibit readonly bitmaps for backups) 15/17 Checking commit ca8fdb5e18fe (block/dirty-bitmaps: prohibit removing readonly bitmaps) 16/17 Checking commit f00e672dd7a8 (block/dirty-bitmaps: disallow busy bitmaps as merge source) 17/17 Checking commit 6a083e7a449c (block/dirty-bitmaps: implement inconsistent bit) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20190308202858.26636-1-js...@redhat.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-de...@redhat.com
