Patchew URL: https://patchew.org/QEMU/20190222055950.17403-1-richard.hender...@linaro.org/
Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20190222055950.17403-1-richard.hender...@linaro.org Subject: [Qemu-devel] [PATCH] tcg/ppc: Add vector opcodes Type: series === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu * [new tag] patchew/1551095970-14645-1-git-send-email-th...@redhat.com -> patchew/1551095970-14645-1-git-send-email-th...@redhat.com * [new tag] patchew/20190221081054.13853-1-kra...@redhat.com -> patchew/20190221081054.13853-1-kra...@redhat.com * [new tag] patchew/20190221173758.24672-1-...@redhat.com -> patchew/20190221173758.24672-1-...@redhat.com * [new tag] patchew/20190222055950.17403-1-richard.hender...@linaro.org -> patchew/20190222055950.17403-1-richard.hender...@linaro.org * [new tag] patchew/20190222170936.13268-1-peter.mayd...@linaro.org -> patchew/20190222170936.13268-1-peter.mayd...@linaro.org Switched to a new branch 'test' 56177b9cb7 tcg/ppc: Add vector opcodes === OUTPUT BEGIN === ERROR: spaces required around that '|' (ctx:VxV) #187: FILE: tcg/ppc/tcg-target.inc.c:327: +#define VX4(opc) (OPCD(4)|(opc)) ^ ERROR: trailing whitespace #552: FILE: tcg/ppc/tcg-target.inc.c:2876: + umin_op[4] = { VMINUB, VMINUH, VMINUW, VMINUD }, $ ERROR: trailing whitespace #553: FILE: tcg/ppc/tcg-target.inc.c:2877: + smin_op[4] = { VMINSB, VMINSH, VMINSW, VMINSD }, $ ERROR: trailing whitespace #554: FILE: tcg/ppc/tcg-target.inc.c:2878: + umax_op[4] = { VMAXUB, VMAXUH, VMAXUW, VMAXUD }, $ WARNING: Block comments use a leading /* on a separate line #623: FILE: tcg/ppc/tcg-target.inc.c:2947: + /* Recall we use VSX integer loads, so the integer is right WARNING: Block comments use * on subsequent lines #624: FILE: tcg/ppc/tcg-target.inc.c:2948: + /* Recall we use VSX integer loads, so the integer is right + justified within the left (zero-index) double-word. */ WARNING: Block comments use a trailing */ on a separate line #624: FILE: tcg/ppc/tcg-target.inc.c:2948: + justified within the left (zero-index) double-word. */ WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #822: new file mode 100644 WARNING: Block comments use a leading /* on a separate line #827: FILE: tcg/ppc/tcg-target.opc.h:1: +/* Target-specific opcodes for host vector expansion. These will be WARNING: Block comments use * on subsequent lines #828: FILE: tcg/ppc/tcg-target.opc.h:2: +/* Target-specific opcodes for host vector expansion. These will be + emitted by tcg_expand_vec_op. For those familiar with GCC internals, WARNING: Block comments use a trailing */ on a separate line #829: FILE: tcg/ppc/tcg-target.opc.h:3: + consider these to be UNSPEC with names. */ total: 4 errors, 7 warnings, 783 lines checked Commit 56177b9cb743 (tcg/ppc: Add vector opcodes) has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20190222055950.17403-1-richard.hender...@linaro.org/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-de...@redhat.com
