"Dr. David Alan Gilbert" <dgilb...@redhat.com> writes:
> * Markus Armbruster (arm...@redhat.com) wrote:
>> "Dr. David Alan Gilbert (git)" <dgilb...@redhat.com> writes:
>>
>> > From: "Dr. David Alan Gilbert" <dgilb...@redhat.com>
>> >
>> > Add a qmp command that can trigger guest announcements.
>> >
>> > It uses its own announce-timer instance, and parameters
>> > passed to it explicitly in the command.
>> >
>> > Like most qmp commands, it's in the main thread/bql, so
>> > there's no racing with any outstanding timer.
>> >
>> > Based on work of Germano Veit Michel <germ...@redhat.com> and
>> > Vladislav Yasevich <vyase...@redhat.com>
>> >
>> > Signed-off-by: Dr. David Alan Gilbert <dgilb...@redhat.com>
>> > Reviewed-by: Michael S. Tsirkin <m...@redhat.com>
>> > ---
>> [...]
>> > diff --git a/qapi/net.json b/qapi/net.json
>> > index 5face0c14b..c093087278 100644
>> > --- a/qapi/net.json
>> > +++ b/qapi/net.json
>> > @@ -707,3 +707,23 @@
>> > 'max': 'int',
>> > 'rounds': 'int',
>> > 'step': 'int' } }
>> > +
>> > +##
>> > +# @announce-self:
>> > +#
>> > +# Trigger generation of broadcast RARP frames to update network switches.
>> > +# This can be useful when network bonds fail-over the active slave.
>> > +#
>> > +# @params: AnnounceParameters giving timing and repetition count of
>> > announce
>> > +#
>> > +# Example:
>> > +#
>> > +# -> { "execute": "announce-self"
>> > +# "arguments": { "params:" {
>> > +# "initial": 50, "max": 550, "rounds": 10, "step": 50 } } }
>> > +# <- { "return": {} }
>> > +#
>> > +# Since: 4.0
>> > +##
>> > +{ 'command': 'announce-self',
>> > + 'data' : {'params': 'AnnounceParameters'} }
>>
>> Any particular reason for the additional level of nesting within
>> "arguments"?
>
> I'd just copied one of the other places; boxed doesn't seem to be used
> that often.
Then let's box here, it's tidier on the wire.
> Dave
>
>> Here's how to avoid it:
>>
>> { 'command': 'announce-self', 'boxed': true,
>> 'data' : 'AnnounceParameters' }
> --
> Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK
