On 07/02/2019 18.57, Paolo Bonzini wrote: > This way, the default-configs file only need to specify the boards > and any optional devices. > > Signed-off-by: Paolo Bonzini <pbonz...@redhat.com> > Signed-off-by: Yang Zhong <yang.zh...@intel.com> > Message-Id: <20190123065618.3520-37-yang.zh...@intel.com> > Signed-off-by: Paolo Bonzini <pbonz...@redhat.com> [...] > --- > diff --git a/hw/i386/Kconfig b/hw/i386/Kconfig > index 0f94ae1..daf2015 100644 > --- a/hw/i386/Kconfig > +++ b/hw/i386/Kconfig > @@ -7,16 +7,65 @@ config PC > imply QXL > imply SEV > imply TPM_TIS > + select I8259 > + select I8254 > + select PCSPK > + select I82374 > + select I8257 > + select MC146818RTC > + > +config PC_PCI > + bool > + select APIC > + select IOAPIC > + select APM > + select PC > + > +config PC_ACPI > + bool > + select ACPI_X86 > + select ACPI_CPU_HOTPLUG > + select ACPI_MEMORY_HOTPLUG > + depends on ACPI_SMBUS > > config I440FX > bool > + select PC_PCI > + select PC_ACPI > + select ACPI_SMBUS > + select PCI_PIIX > + select FDC > + select IDE_PIIX > + select DIMM > + select SMBIOS > + select VMPORT > + select VMMOUSE > + select FW_CFG_DMA
Just a thought: Should we also "imply E1000_PCI" here to indicate the default NIC? > config ISAPC > bool > select ISA_BUS > + select PC > + select IDE_ISA > + select VGA_ISA ISAPC seems also to work without a vga card when you specify -nodefaults, so I think this should be "imply VGA_ISA" instead. Maybe also "imply NE2000_ISA" for the default NIC? > + # FIXME: it is in the same file as i440fx, and does not compile > + # if separated > + depends on I440FX > > config Q35 > bool > + imply VTD > + imply AMD_IOMMU > + select PC_PCI > + select PC_ACPI > + select PCI_EXPRESS_Q35 > + select LPC_ICH9 > + select AHCI > + select DIMM > + select SMBIOS > + select VMPORT > + select VMMOUSE > + select FW_CFG_DMA Maybe add "imply E1000E_PCI_EXPRESS" for the default NIC? Thomas
