On 06.02.19 14:18, Igor Mammedov wrote: > On Thu, 31 Jan 2019 15:52:25 +0100 > David Hildenbrand <da...@redhat.com> wrote: > >> On 28.01.19 15:18, Igor Mammedov wrote: >>> On Wed, 23 Jan 2019 20:55:18 +0100 >>> David Hildenbrand <da...@redhat.com> wrote: >>> >>>> This series implements supprt for hotplug handler chaining (proposed >>>> by Igor), something that is necessary to turn selected virtio devices into >>>> memory devices. Planned devices inlude virtio-mem and virtio-pmem. The >>>> current prototype of virtio-pmem is included. >>>> >>>> The machine hotplug handler can intercept hotplug handler calls >>>> to properly prepare/teardown the memory device part of a device. Control >>>> is then passed on to the actual bus hotplug handler. So the default hotplug >>>> handler is effectively overwritten to make interception possible. >>>> >>>> It is based on the following patches/series >>>> - [PATCH v1] pc: Use hotplug_handler_(plug|unplug|unplug_request) >>>> -- Queued by Paolo >>>> - [PATCH v3 0/2] s390x/pci: hotplug handler fixes and reworks >>>> >>>> Patch 1-3 are the preparations for hotplug handler chaining. >>> we probably should merge this ones even without pmem patches. >> >> Just to verify, does the general approach on how to hotplug virtio based >> memory devices now looks okay to you? > it looks fine (minor comments aside)
Thanks a lot for taking your time to look into this Igor, highly appreciated! > > rant: beside a little bit complex dance with nowadays virtio type names > but that's not related to your series. It just makes understanding virtio > code more difficult not saying it's wasn't already complicated to begin with. Entropy of an isolated system can never decrease over time :D -- Thanks, David / dhildenb
