On Fri, 7 Dec 2018 at 09:08, Hongbo Zhang <hongbo.zh...@linaro.org> wrote:
>
> Following the previous patch, this patch adds peripheral devices to the
> newly introduced SBSA-ref machine.
>
> Signed-off-by: Hongbo Zhang <hongbo.zh...@linaro.org>
> ---
> hw/arm/sbsa-ref.c | 421
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 421 insertions(+)
Most of this code looks good, thanks.
> +
> +static void sbsa_ref_machine_done(Notifier *notifier, void *data)
> +{
> + VirtMachineState *vms = container_of(notifier, VirtMachineState,
> + machine_done);
> + ARMCPU *cpu = ARM_CPU(first_cpu);
> + struct arm_boot_info *info = &vms->bootinfo;
> + AddressSpace *as = arm_boot_address_space(cpu, info);
> +
> + if (arm_load_dtb(info->dtb_start, info, info->dtb_limit, as) < 0) {
> + exit(1);
> + }
> +}
I still don't understand why we need this -- it doesn't seem
to be doing anything different from the default behaviour that
boot.c implements if skip_dtb_autoload is false.
thanks
-- PMM
