On Tue, Jan 22, 2019 at 09:33:37AM -0800, Dan Williams wrote: > On Mon, Jan 21, 2019 at 7:27 PM Michael S. Tsirkin <m...@redhat.com> wrote: > [..] > > > 2. The reset of cases: > > > - we will never pass the MAP_SYNC to mmap2 > > > > I don't see code probing for MAP_SYNC support. Did I miss it? > > But if all you want is to have old linux ignore MAP_SYNC, > > I think you got your wish automatically - just do not set > > MAP_SHARED_VALIDATE. > > That will also cause new Linux to ignore MAP_SYNC.
Oh you are right. I missed this point. And given that these patches do not seem to set MAP_SHARED_VALIDATE at all I conclude that even though thet set MAP_SYNC it actually has no effect at all. So I wonder how they were tested. Would the contributors care to elaborate? That would be good info to put in the commit log message. -- MST
