On 1/14/19 5:38 AM, Daniel P. Berrangé wrote: > The qio_channel_socket_close method for was mistakenly unlinking the > UNIX server socket, even if the channel was a client connection. This > was not noticed with chardevs, since they never call close, but with the > VNC server, this caused the VNC server socket to be deleted after the > first client quit. > > The qio_channel_socket_close method also needlessly reimplemented the > logic that already exists in socket_listen_cleanup(). Just call that > method directly, for listen sockets only. > > This fixes a regression introduced in QEMU 3.0.0 with > > commit d66f78e1eaa832f73c771d9df1b606fe75d52a50 > Author: Pavel Balaev <m...@void.so> > Date: Mon May 21 19:17:35 2018 +0300 > > Delete AF_UNIX socket after close > > Fixes launchpad #1795100 > > Signed-off-by: Daniel P. Berrangé <berra...@redhat.com> > --- > io/channel-socket.c | 19 ++------ > tests/test-io-channel-socket.c | 86 ++++++++++++++++++++++++++++++---- > 2 files changed, 80 insertions(+), 25 deletions(-)
Reviewed-by: Eric Blake <ebl...@redhat.com> -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
