On 13.12.18 17:27, Laurent Vivier wrote: > Signed-off-by: Laurent Vivier <lviv...@redhat.com> > Reviewed-by: Philippe Mathieu-Daudé <phi...@redhat.com> > --- > > Notes: > v2: replace "sd_" prefix by "sheepdog_" > remove the dot at the end of the text strings > > block/sheepdog.c | 47 +++++++++++++++++----------------------------- > block/trace-events | 14 ++++++++++++++ > 2 files changed, 31 insertions(+), 30 deletions(-) > > diff --git a/block/sheepdog.c b/block/sheepdog.c > index 0125df9d49..8b95cde01a 100644 > --- a/block/sheepdog.c > +++ b/block/sheepdog.c
[...] > diff --git a/block/trace-events b/block/trace-events > index 06dbe65080..358c0e3c11 100644 > --- a/block/trace-events > +++ b/block/trace-events > @@ -189,3 +189,17 @@ file_xfs_discard(const char* error) "cannot punch hole > (%s)" [...] > +sheepdog_snapshot_create_inode(const char *name, uint32_t snap, uint32_t > vdi) "s->inode: name %s snap_id 0x%x vdi 0x%x" Good point in giving @snap and @vdi the correct types, but then the format string should follow suit. :-) Max
