Hi Eric,
On 1/11/19 9:13 PM, Eric Blake wrote:
> When qemu dies from a signal, the python code gets a negative
> value for exitcode; but signal numbers are positive. Copy the
> pattern used in qemu-iotests/iotests.py for reporting a positive
> value.
>
> CC: qemu-triv...@nongnu.org
> Signed-off-by: Eric Blake <ebl...@redhat.com>
> ---
> scripts/qemu.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/qemu.py b/scripts/qemu.py
> index 6e3b0e67719..0a5e02eb56e 100644
> --- a/scripts/qemu.py
> +++ b/scripts/qemu.py
> @@ -351,7 +351,7 @@ class QEMUMachine(object):
> command = ' '.join(self._qemu_full_args)
> else:
> command = ''
> - LOG.warn(msg, exitcode, command)
> + LOG.warn(msg, -exitcode, command)
What about displaying signal name directly?
import signal
...
msg = 'qemu received %s: %s'
...
LOG.warn(msg, signal.Signals(-exitcode).name, command)
>
> self._launched = False
>
