On 1/11/19 1:47 PM, Eric Blake wrote: > Or rather, move its functionality into nbd-server-add. And as > a side effect, teach qemu-nbd how to export a persistent bitmap > without having to go through a qemu process and several QMP > commands. > > Based-on: <20181221093529.23855-1-js...@redhat.com> > [jsnow: 0/11 bitmaps: remove x- prefix from QMP api] > Based-on: <20190111163519.11457-1-phi...@redhat.com> > [philmd: qemu-nbd: Rename 'exp' variable clashing with math::exp() symbol] > > Available at: https://repo.or.cz/qemu/ericb.git nbd-bitmap-add-v3 > > Since v2: > - split old patch 1 into 3 parts > - add even more tests of expected error messages > - rebase on top of 'exp' rename > - improve commit messages > - add some R-b where it made sense > > 001/8:[down] 'nbd: Add some error case testing to iotests 223' > 002/8:[down] 'nbd: Forbid nbd-server-stop when server is not running' > 003/8:[0011] [FC] 'nbd: Only require disabled bitmap for read-only exports' > 004/8:[0020] [FC] 'nbd: Merge nbd_export_set_name into nbd_export_new' > 005/8:[0008] [FC] 'nbd: Allow bitmap export during QMP nbd-server-add' > 006/8:[----] [--] 'nbd: Remove x-nbd-server-add-bitmap' > 007/8:[0009] [FC] 'nbd: Merge nbd_export_bitmap into nbd_export_new' > 008/8:[0004] [FC] 'qemu-nbd: Add --bitmap=NAME option'
Queuing on my NBD tree; I'm planning on sending a pull request Monday morning that includes these patches, unless a last-minute review finding changes things. https://repo.or.cz/qemu/ericb.git nbd -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
