On Fri, Jan 11, 2019 at 5:27 PM Stefan Hajnoczi <stefa...@gmail.com> wrote: > > On Fri, Jan 11, 2019 at 02:18:34PM +0100, Stefano Garzarella wrote: > > In order to allow other option roms to use these common > > useful functions and definitions, this patch put them > > in a new C header file called optrom.h, and also add > > useful out*() in*() functions for different size. > > It's usually helpful to modify code in a one patch and move it in a > separate patch. This patch does both, so it's a harder to review. > Don't worry about changing it now, but something to try in the future.
Thanks for the tip! > > > +#include <stdint.h> > > +#include "optrom.h" > > +#include "optrom_fw_cfg.h" > > Can these be moved to the top of the file like a regular C source file? Yes, I'll move them to the top. > > > diff --git a/pc-bios/optionrom/optrom.h b/pc-bios/optionrom/optrom.h > > new file mode 100644 > > index 0000000000..36f43b43fd > > --- /dev/null > > +++ b/pc-bios/optionrom/optrom.h > > @@ -0,0 +1,109 @@ > > +/* > > + * Common Option ROM Functions for C code > > + * > > + * This program is free software; you can redistribute it and/or modify > > + * it under the terms of the GNU General Public License as published by > > + * the Free Software Foundation; either version 2 of the License, or > > + * (at your option) any later version. > > + * > > + * This program is distributed in the hope that it will be useful, > > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > > + * GNU General Public License for more details. > > + * > > + * You should have received a copy of the GNU General Public License > > + * along with this program; if not, see <http://www.gnu.org/licenses/>. > > + * > > + * Copyright (c) 2015-2019 Red Hat Inc. > > + * Authors: > > + * Marc Marí <marc.mari.barc...@gmail.com> > > + * Richard W.M. Jones <rjo...@redhat.com> > > + * Stefano Garzarella <sgarz...@redhat.com> > > + */ > > + > > +#ifndef OPTROM_H > > +#define OPTROM_H > > + > > +#include "../../include/standard-headers/linux/qemu_fw_cfg.h" > > This depends on <stdint.h>, please include it first. Sure. Thanks, Stefano -- Stefano Garzarella Red Hat
