On Tue, Jan 08, 2019 at 12:42:06PM +0100, Paolo Bonzini wrote: > On 08/01/19 09:04, Yang Zhong wrote: > > On Fri, Jan 04, 2019 at 02:39:50PM +0100, Thomas Huth wrote: > >> On 2018-12-27 07:34, Yang Zhong wrote: > >>> From: Paolo Bonzini <pbonz...@redhat.com> > >>> > >>> This lets you disable SCSI altogether with "CONFIG_SCSI=n". > >>> > >>> Signed-off-by: Paolo Bonzini <pbonz...@redhat.com> > >>> Signed-off-by: Yang Zhong <yang.zh...@intel.com> > >>> --- > >>> hw/scsi/Kconfig | 11 ++++++++++- > >>> hw/scsi/Makefile.objs | 2 +- > >>> 2 files changed, 11 insertions(+), 2 deletions(-) > >>> > >>> diff --git a/hw/scsi/Kconfig b/hw/scsi/Kconfig > >>> index 6e7575397f..d669a4824e 100644 > >>> --- a/hw/scsi/Kconfig > >>> +++ b/hw/scsi/Kconfig > >>> > >>> -config PSERIES > >>> +config SPAPR_VSCSI > >>> bool > >>> + select SCSI > >> > >> I think this should get "default y" and "depends on PSERIES" now. > >> > >> Thomas > > > > Hello Thomas, > > > > I greped CONFIG_PSERIES from current Kconfig repo and got below list > > ./hw/net/Makefile.objs:obj-$(CONFIG_PSERIES) += spapr_llan.o > > ./hw/ppc/Makefile.objs:obj-$(CONFIG_PSERIES) += spapr.o spapr_caps.o > > spapr_vio.o spapr_events.o > > ./hw/ppc/Makefile.objs:obj-$(CONFIG_PSERIES) += spapr_hcall.o > > spapr_iommu.o spapr_rtas.o > > ./hw/ppc/Makefile.objs:obj-$(CONFIG_PSERIES) += spapr_pci.o spapr_rtc.o > > spapr_drc.o > > ./hw/ppc/Makefile.objs:obj-$(CONFIG_PSERIES) += spapr_cpu_core.o > > spapr_ovec.o spapr_irq.o > > ./hw/ppc/Makefile.objs:ifeq > > ($(CONFIG_PCI)$(CONFIG_PSERIES)$(CONFIG_LINUX), yyy) > > ./hw/ppc/Makefile.objs:obj-$(CONFIG_PSERIES) += spapr_rtas_ddw.o > > ./hw/char/Makefile.objs:obj-$(CONFIG_PSERIES) += spapr_vty.o > > ./hw/nvram/Makefile.objs:obj-$(CONFIG_PSERIES) += spapr_nvram.o > > ./default-configs/ppc64-softmmu.mak:CONFIG_PSERIES=y > > ./default-configs/ppc64-softmmu.mak:CONFIG_XICS=$(CONFIG_PSERIES) > > ./default-configs/ppc64-softmmu.mak:CONFIG_XICS_SPAPR=$(CONFIG_PSERIES) > > ./default-configs/ppc64-softmmu.mak:CONFIG_XICS_KVM=$(call > > land,$(CONFIG_PSERIES),$(CONFIG_KVM)) > > > > Since this time is only for x86 and i did not add Kconfig file in > > hw/ppc/, i did not add > > this dependency too in here. > > > > In previous plan, i will add "config PSERRIES" in hw/ppc/Kconfig file for > > PowerPC pSeries > > and will add dependency in that time, thanks. > > You could skip the conversion to Kconfig of default-configs/, but > already add all "source hw/ARCH/Kconfig" statements to hw/Kconfig and > all "select" statements for buses. Then, all machine types for example > could start removing CONFIG_SCSI=y and CONFIG_PCI=y, even if you do not > have the machines converted. > Hello Paolo,
Okay, i will add extra patches for other machines and only keep ARCHs dependency for default-configs/*-softmmu.mak in next stage. The new patches will include: 1) hw/ARCH/Makefile configurable 2) Add Kconfig into hw/ARCH/ 3) convert bus, like pci, usb in other ARCHs Regards, Yang > Paolo
