Fei Li <f...@suse.com> writes:
> Always call migrate_set_error() to set the error state without relying
> on whether multifd_save_cleanup() succeeds. As the passed &local_err
> is never used in multifd_save_cleanup(), remove it. And make the
> function be: void multifd_save_cleanup(void).
>
> Cc: Dr. David Alan Gilbert <dgilb...@redhat.com>
> Signed-off-by: Fei Li <f...@suse.com>
> Reviewed-by: Juan Quintela <quint...@redhat.com>
The commit message is confusing. Suggest:
migration: multifd_save_cleanup() can't fail, simplify
multifd_save_cleanup() takes an Error ** argument and returns an
error code even though it can't actually fail. Its callers
dutifully check for failure. Remove the useless argument and return
value, and simplify the callers.
I think multifd_load_cleanup() has exactly the same issue. Should we
clean it up, too? Juan, what do you think?
