On 17/12/2018 16:40, Richard Henderson wrote: > On 12/17/18 4:23 AM, Mark Cave-Ayland wrote: >> These helpers allow us to move FP register values to/from the specified >> TCGv_i64 >> argument in the VSR helpers to be introduced shortly. >> >> To prevent FP helpers accessing the cpu_fpr array directly, add extra TCG >> temporaries as required. >> >> Signed-off-by: Mark Cave-Ayland <mark.cave-ayl...@ilande.co.uk> >> --- >> target/ppc/translate.c | 10 + >> target/ppc/translate/fp-impl.inc.c | 490 >> ++++++++++++++++++++++++++++--------- >> 2 files changed, 390 insertions(+), 110 deletions(-) > > Reviewed-by: Richard Henderson <richard.hender...@linaro.org>
Howard has notified me off-list of a regression he noticed in OS X, which I've traced down to an erroneous extra get_fpr() in the GEN_FLOAT_* macro changes in this patch. I've pushed the fixed version of this patchset to https://github.com/mcayland/qemu/tree/ppc-altivec for those who wish to experiment before I send out a v3 later in the week (I feel reasonably confident now to drop the RFC for the next iteration). ATB, Mark.
