On Wed, 12 Dec 2018 15:25:57 -0500 Collin Walling <wall...@linux.ibm.com> wrote:
> On 11/30/2018 04:27 AM, Cornelia Huck wrote: > > On Fri, 30 Nov 2018 10:23:14 +0100 > > Pierre Morel <pmo...@linux.ibm.com> wrote: > > > >> On 31/10/2018 11:49, Cornelia Huck wrote: > >>> On Wed, 24 Oct 2018 11:58:33 +0800 > >>> Yi Min Zhao <zyi...@linux.ibm.com> wrote: > >>> > >>>> 在 2018/10/24 上午5:25, Cornelia Huck 写道: > >>>>> On Mon, 22 Oct 2018 13:17:34 +0100 > >>>>> Thomas Huth <th...@redhat.com> wrote: > >>>>> > >> > >> ...snip... > >> > >>>> If endianness has error, I think the values must looks wrong. > >>>> The right thing is that values increase from 0 and intervally. > >>>> > >>> > >>> Thanks for pointing me to that file; when I run under tcg, the values > >>> indeed look like they have an endianness issue: > >>> > >>> Update interval: 4000 ms > >>> Samples: 637534208 > >>> Last update TOD: f4c01d0098000000 > >>> Load operations: 10520408729537478656 > >>> Store operations: 5980780305148018688 > >>> Store block operations: 0 > >>> Refresh operations: 0 > >>> Allocated pages: 0 > >>> Mapped pages: 0 > >>> Unmapped pages: 0 > >>> > >>> (virtio-net-pci device on a just-booted guest) > >>> > >> > >> Hy Conny, > >> > >> I saw we lack a response to Thomas. > >> Otherwise have you any remark? > > > > I don't remember anything beyond the endianess issue. > > > > This patch looks sane to me (I've lost the parent email on my > client, else I would've replied directly to that). > > I'm currently awaiting getting my system up-and-running to test > this thoroughly. Shall we do one more round with the endianess > addressed in the mean time? Sure; I'll need to rely on your testing anyway (but I'll give it a whirl with virtio-pci).