On Wed, 5 Dec 2018 at 20:58, Eduardo Habkost <ehabk...@redhat.com> wrote:
>
> All instance_init functions for all virt machine-types run
> exactly the same code, so we don't need separate functions. We
> only need to set instance_init for TYPE_VIRT_MACHINE.
>
> Signed-off-by: Eduardo Habkost <ehabk...@redhat.com>
> ---
> hw/arm/virt.c | 87 +++++++++++++--------------------------------------
> 1 file changed, 21 insertions(+), 66 deletions(-)
>
> +static const TypeInfo virt_machine_info = {
> + .name = TYPE_VIRT_MACHINE,
> + .parent = TYPE_MACHINE,
> + .abstract = true,
> + .instance_size = sizeof(VirtMachineState),
> + .class_size = sizeof(VirtMachineClass),
> + .class_init = virt_machine_class_init,
> + .instance_init = virt_instance_init,
Indentation looks like it's not quite right here.
> + .interfaces = (InterfaceInfo[]) {
> + { TYPE_HOTPLUG_HANDLER },
> + { }
> + },
> +};
Otherwise
Reviewed-by: Peter Maydell <peter.mayd...@linaro.org>
thanks
-- PMM
