On Wed, Dec 05, 2018 at 06:58:25PM -0200, Eduardo Habkost wrote: > Instead of setting suppress_vmdesc at instance_init time, set > default_machine_opts on spapr_machine_2_2_class_options() to > implement equivalent behavior. > > This will let us eliminate the need for separate instance_init > functions for each spapr machine-type. > > Signed-off-by: Eduardo Habkost <ehabk...@redhat.com>
Acked-by: David Gibson <da...@gibson.dropbear.id.au>
> ---
> hw/ppc/spapr.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c
> index f6b60e6fbd..0c3b27a8cc 100644
> --- a/hw/ppc/spapr.c
> +++ b/hw/ppc/spapr.c
> @@ -4368,13 +4368,13 @@ DEFINE_SPAPR_MACHINE(2_3, "2.3", false);
> static void spapr_machine_2_2_instance_options(MachineState *machine)
> {
> spapr_machine_2_3_instance_options(machine);
> - machine->suppress_vmdesc = true;
> }
>
> static void spapr_machine_2_2_class_options(MachineClass *mc)
> {
> spapr_machine_2_3_class_options(mc);
> SET_MACHINE_COMPAT(mc, SPAPR_COMPAT_2_2);
> + mc->default_machine_opts =
> "modern-hotplug-events=off,suppress-vmdesc=on";
> }
> DEFINE_SPAPR_MACHINE(2_2, "2.2", false);
>
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature
