On Wed, Dec 5, 2018 at 12:21 PM Markus Armbruster <arm...@redhat.com> wrote: > > Marc-André Lureau <marcandre.lur...@redhat.com> writes: > > > Chardev backends may not handle safely IO events from concurrent > > threads (they are not thread-safe in general, only the write path is > > Suggest "may not handle I/O events from concurrent threads safely". > > > since commit > 9005b2a7589540a3733b3abdcfbccfe7746cd1a1). Better to > > wake up the chardev from the monitor IO thread if it's being used as > > the chardev context. > > > > Unify code paths by using a BH in all cases. > > > > Drop the now redundant aio_notify() call. > > > > Simplify the condition, based on mon->use_io_thread (only QMP so far). > > Suggest > > Clean up control flow not to rely on mon->use_io_thread implying > monitor_is_qmp(mon). > > > Signed-off-by: Marc-André Lureau <marcandre.lur...@redhat.com> > > Reviewed-by: Peter Xu <pet...@redhat.com> > > Happy to improve the commit message in my tree. > > Preferably with commit message improvements: > Reviewed-by: Markus Armbruster <arm...@redhat.com> >
ack, thanks -- Marc-André Lureau
