On Thu, Nov 29, 2018 at 09:45:17AM -0600, Corey Minyard wrote: > On 11/26/18 12:28 PM, miny...@acm.org wrote: > > From: Corey Minyard <cminy...@mvista.com> > > > > Otherwise it won't be set up correctly and won't work after > > miigration. > > Any opinions on this? I think this would be good for 3.1. Without > this when a migration occurs on piix4 the SMBus address space > appears in the wrong place. I'm not sure how bad that is, but > SMBus certainly ceases to work. > > -corey
I have this queued. Thanks! > > > Signed-off-by: Corey Minyard <cminy...@mvista.com> > > Cc: Michael S. Tsirkin <m...@redhat.com> > > Cc: Igor Mammedov <imamm...@redhat.com> > > --- > > hw/acpi/piix4.c | 1 + > > 1 file changed, 1 insertion(+) > > > > A rather obvious fix, in hindsight :). > > > > diff --git a/hw/acpi/piix4.c b/hw/acpi/piix4.c > > index e330f24c71..2f4dd03b83 100644 > > --- a/hw/acpi/piix4.c > > +++ b/hw/acpi/piix4.c > > @@ -173,6 +173,7 @@ static int vmstate_acpi_post_load(void *opaque, int > > version_id) > > PIIX4PMState *s = opaque; > > pm_io_space_update(s); > > + smbus_io_space_update(s); > > return 0; > > } >
