On 13/11/18 18:01, Peter Maydell wrote:
On 13 November 2018 at 16:52, Samuel Ortiz <sa...@linux.intel.com> wrote:
From: Philippe Mathieu-Daudé <phi...@redhat.com>
Signed-off-by: Philippe Mathieu-Daudé <phi...@redhat.com>
Reviewed-by: Robert Bradford <robert.bradf...@intel.com>
Reviewed-by: Samuel Ortiz <sa...@linux.intel.com>
---
target/arm/helper.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/target/arm/helper.c b/target/arm/helper.c
index 3d4e9c5c8a..27d9285e1e 100644
--- a/target/arm/helper.c
+++ b/target/arm/helper.c
@@ -12,13 +12,10 @@
#include "internals.h"
#include "exec/gdbstub.h"
#include "exec/helper-proto.h"
-#include "qemu/host-utils.h"
This is for muldiv64().
But it is already included by "cpu.h" -> "exec/cpu-defs.h"
#include "sysemu/arch_init.h"
#include "sysemu/sysemu.h"
-#include "qemu/bitops.h"
"cpu.h" -> "cpu-qom.h" -> "qom/cpu.h" -> "qemu/bitmap.h"
This is for extract32() and friends.
#include "qemu/crc32c.h"
#include "exec/exec-all.h"
-#include "exec/cpu_ldst.h"
This is for cpu_stl_data().
Included by "arm_ldst.h"
#include "arm_ldst.h"
#include <zlib.h> /* For crc32 */
#include "exec/semihost.h"
So they are not "unused" but "unnecessary".
I thought this would be better to clean this once, before Samuel split.
Samuel: please drop this patch from your series.
Thanks,
Phil.
